Open
Conversation
Member
|
@MarkToner looks like there's lots of good stuff in this PR, can you please fix the linting issues, and then we will give this a proper review? Thanks! |
Author
|
@james-d-mitchell Will do as soon as soon as possible! |
mtorpey
reviewed
Jun 4, 2025
Collaborator
mtorpey
left a comment
There was a problem hiding this comment.
I can see a few changes that you must have committed by accident, which seem to be preventing tests from passing. Take a look at the lines I've commented on, and probably just revert them. That might get the last tests passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added functionality for computing the crossing number of digraphs, both actual values and upper and lower bounds.
Also added miscellaneous functionality to support this goal:
All functionality has been tested, with all public-facing functionality documented.